fix(rules): rule triggering on late-connecting targets #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build_test |
|
/build_test |
To run smoketest: |
To run smoketest: |
|
/build_test |
To run smoketest: |
andrewazores
force-pushed
the
gh1494
branch
3 times, most recently
from
99bd4f0 to
4bc613f
Compare
|
/request_review |
aali309
reviewed
Sep 6, 2023
aali309
previously approved these changes
Sep 6, 2023
|
/build_test |
To run smoketest: |
mwangggg
reviewed
Sep 7, 2023
andrewazores
force-pushed
the
gh1494
branch
from
d0b7509 to
8720914
Compare
|
regarding the issue I was having with the vertx-fib-demo-2 targets, it seems to have been resolved for the most part. I just tested it by making the same automated rule |
|
Okay, I think that would indeed be some deeper piece of networking code then, not specifically related to the rules triggering system, so we should track that as a separate issue and try to get more details about what is causing the thread block. |
|
Probably the same as #1669 ^ |
|
other than that, this PR looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes #1494
Fixes #1497
Related to #1593
Description of the change:
This changeset:
MODIFIEDJVM discovery events in a couple of places. Primarily to avoid anUnsupportedOperationExceptionthat was wrongly thrown and could cause rule activations to fail, and then secondarily to use these events to trigger a proactive re-check of non-connectable targets in case the discovery update made the target connectable.enabledstate - this equality bug actually was a root cause for the broken deactivate/reactivate workflowsMotivation for the change:
This should fix the bug where rules may not activate against targets that appear but are not immediately connectable, and should also shorten the time it takes for Cryostat to detect that a slowly-connectable target becomes connectable.
How to manually test:
Deploy test image in
crcor other OpenShift/k8s. Deploy a sample application. Quite often, the k8s server notifies Cryostat of the new Endpoints object before the target JVM is actually ready to accept JMX connections, so the initial JVM ID retrieval attempt fails and so does the initial attempt to trigger automated rules. After this change, this workflow should again work as expected and Cryostat should notice that the target becomes connectable, and then triggers automated rules against it.