Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(smoketest): remove Agent prefer-jmx env var #1678

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Depends on cryostatio/cryostat-agent#203
Related to cryostatio/cryostat-agent#166

@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Sep 20, 2023
@github-actions
Copy link
Contributor

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@github-actions github-actions bot added dependent needs-triage Needs thorough attention from code reviewers and removed dependent labels Sep 20, 2023
@mergify mergify bot added the safe-to-test label Sep 20, 2023
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Sep 20, 2023
@github-actions
Copy link
Contributor

This PR/issue depends on:

Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewazores andrewazores merged commit f7df109 into cryostatio:main Sep 22, 2023
7 checks passed
@andrewazores andrewazores deleted the agent-dual-registration branch September 22, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants