fix(notifications): parse detail for notification body #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
reviewed
Jan 2, 2024
mwangggg
force-pushed
the
1120-error-response-cleanup
branch
2 times, most recently
from
54c6456 to
9f7c7b6
Compare
mwangggg
force-pushed
the
1120-error-response-cleanup
branch
from
6730633 to
2a3879e
Compare
7 tasks
andrewazores
added
dependent
and removed
dependencies
andrewazores
approved these changes
Feb 6, 2024
|
/build_test |
|
CI failure due to -core not being buildable because it's still trying to pull and build an old version that has the broken I'm trying to get -core 2.28.0 onto Maven Central now. If/when that works and we update all our projects to that dependency version then we should be finally out of the woods with this GitHub Packages Maven mess and not need authentication to download the dependency, or need to rebuild it like this in other project dependency chains, etc. |
|
Should be OK after cryostatio/cryostat#279 : https://repo.maven.apache.org/maven2/io/cryostat/cryostat-core/ |
|
/build_test |
|
Test image available: |
andrewazores
force-pushed
the
1120-error-response-cleanup
branch
from
2a3879e to
fe45815
Compare
andrewazores
force-pushed
the
1120-error-response-cleanup
branch
from
fe45815 to
87c90f1
Compare
andrewazores
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #1120
Depends on: cryostatio/cryostat#260