Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): fix Link routing when using custom basepath #1539

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Jan 24, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


This is a follow-up to: #1534

Description of the change:

The PR listed above made changes to allow setting a base path for routes, but missed instances of <Link>, so this PR adds the toPath() to those elements.

Motivation for the change:

Fixes routing using <Link> elements when using a custom base path.

@aptmac aptmac added the fix label Jan 24, 2025
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it might be nice to refactor out something like a <CryostatLink> component, which is just a wrapper around <Link> with the toPath call internalized.

@aptmac
Copy link
Member Author

aptmac commented Jan 24, 2025

Had forgotten to sign my commits, that should be better.

@andrewazores andrewazores merged commit e3838b9 into cryostatio:main Jan 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants