Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): correctly append query parameters #1547

Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jan 30, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


See #1544

Description of the change:

When the request already contains query parameters, for example when originating from the Archives view where a ?tab=foo query parameter is used for routing to the specific tabbed subview, the previous logic would incorrectly build a query string like ?tab=foo?ns=namespace&name=cryostat. Note the doubled-up ?.

@andrewazores andrewazores marked this pull request as ready for review January 31, 2025 03:43
@andrewazores andrewazores requested a review from aptmac January 31, 2025 03:43
@andrewazores andrewazores merged commit b519094 into cryostatio:main Jan 31, 2025
13 checks passed
@andrewazores andrewazores deleted the notification-channel-query-params branch January 31, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants