-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(reports): use CryostatContext url and headers for reportJson #1550
chore(reports): use CryostatContext url and headers for reportJson #1550
Conversation
From the perspective of making the request and properly hitting the backend for the console plugin, this PR looks to do the trick. From the perspective of displaying the report, it's a bit trickier. On first load the report is not cached, so the response is a 202 while the component displays a spinner. If I "refresh" the view by opening the console global nav or switching to the Archived Recordings tab and then back, then the report will (often) display. In the cases where it doesn't display the report, it shows the spinner again but then in the Chrome Console I see repeated: and in the plugin backend:
Will continue looking into this one |
I think the |
^ cryostatio/cryostat#286 (comment) In this case, the expected flow is:
|
Thanks for the breakdown of the paths, I was missing updated urls and headers further down the chain for handling the 202 response. This looks to be running okay now. While testing in crc I was looking into some of the timings, because you had noticed the increase in build time lately. It looks like most of the time is spent doing |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Fixes #1551
Description of the change:
Currently have this in draft while I wait for my container build to finish so I can test it with the console plugin in crc. At the moment cryostat-web looks okay in dev preview (both by itself and through a local console).
This PR updates the
reportJson()
to use the url and headers from CryostatContext when requesting the automated analysis.Motivation for the change:
Without the url and headers the console plugin is unable to make the proper request in order to request the json.