fix(notifications): More descriptive notifications

[mwangggg]

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

---

Related to cryostatio/cryostat-web#1192

[aali309]

Looks good.

[aali309]

/build_test

[github-actions]

You do not have permission to run the /build_test command. Please ask @cryostatio/reviewers
to resolve the issue.

[mwangggg]

/build_test

[github-actions]

You do not have permission to run the /build_test command. Please ask @cryostatio/reviewers
to resolve the issue.

[andrewazores]

Weird.

[mwangggg]

seems to be just ths PR :/

[andrewazores]

Here's a rough idea:

---

public static class RuleExistsException extends EntityExistsException {
  RuleExistsException(String name) {
    super("Rule", name);
  }
}

public static class EntityExistsException extends ClientErrorException {
  EntityExistsException(String type, String name) {
    super(String.format("%s with name %s already exists", type, name), Response.Status.CONFLICT);
  }
}

and then move the @ServerExceptionMapper into ExceptionMappers.java and have it check e instanceof EntityExistsException instead of the Rule-specific one.

WDYT?

[mwangggg]

Here's a rough idea:

public static class RuleExistsException extends EntityExistsException {
  RuleExistsException(String name) {
    super("Rule", name);
  }
}

public static class EntityExistsException extends ClientErrorException {
  EntityExistsException(String type, String name) {
    super(String.format("%s with name %s already exists", type, name), Response.Status.CONFLICT);
  }
}

and then move the @ServerExceptionMapper into ExceptionMappers.java and have it check e instanceof EntityExistsException instead of the Rule-specific one.

WDYT?

should this also be an EntityExistsException?
https://github.com/cryostatio/cryostat3/blob/bd6f61d05436f26fcbf8d3edd27e767be21dc8c9/src/main/java/io/cryostat/recordings/RecordingHelper.java#L157-L160

[andrewazores]

Yup, looks like that would make sense.

[mwangggg]

I moved the EntityExistsException class out to the io.Cryostat package since it's being used by both recordings and rules- let me know if there's somewhere better to put it? Or I could rename and leave the file as a general place for new exceptions that are used by more than one component of Cryostat...

[andrewazores]

/build_test

[github-actions]

Workflow started at 2/6/2024, 2:52:24 PM. View Actions Run.

[github-actions]

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7805294974

[github-actions]

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/7805294974