Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(flake): enable flakey test reruns, disable problematic tests in CI #151

Merged
merged 15 commits into from
Nov 8, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #147

This simply adds a configuration to allow the test runners to retry failing tests up to 5 times. I will continue investigating what actually causes these tests to fail at such a high rate, but flakey integration tests are currently making PR reviews much more cumbersome than they should be because CI results can't be trusted.

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Nov 8, 2023
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Nov 8, 2023
@andrewazores andrewazores changed the title test(flake): enable flakey test reruns test(flake): enable flakey test reruns, disable problematic tests in CI Nov 8, 2023
@andrewazores andrewazores marked this pull request as ready for review November 8, 2023 17:55
@andrewazores andrewazores requested a review from a team as a code owner November 8, 2023 17:55
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now with the changes.
image

@andrewazores andrewazores merged commit 167184b into cryostatio:main Nov 8, 2023
8 checks passed
@andrewazores andrewazores deleted the flaky-itests branch November 8, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants