test(redirects): refactor redirect handling

[andrewazores]

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

---

Related to #150

Description of the change:

Refactors redirect handling utility methods into a WebClient extension

Motivation for the change:

Slight clean up for encapsulation and clarify between what is a base webclient capability versus what is an extension for our integration tests only

[andrewazores]

/build_test

[andrewazores]

@aali309 doesn't seem to have run ^ looks like everything got skipped: https://github.com/cryostatio/cryostat3/actions/runs/6813168509

[aali309]

/build_test

[andrewazores]

https://github.com/cryostatio/cryostat3/actions/runs/6813244135

[aali309]

Works well for me after pulling latest code.
https://github.com/aali309/cryostat3/actions/runs/6813400456

[andrewazores]

Not sure what you mean. This PR is already rebased on the latest main - is there some other code I need to pull in too?

[andrewazores]

Usually the "this job was skipped" message/status on those workflows means that there was an if: condition on the workflow/step that evaluated to false.

https://github.com/cryostatio/cryostat3/actions/runs/6813168509/workflow

It seems like the first step must be the one that was skipped, and the rest have needs: [] on it, so they got skipped as well since they are dependent. So really the only if: that causes this must be here:

https://github.com/cryostatio/cryostat3/actions/runs/6813168509/workflow#L19

I don't know why that would be evaluating to false though.

[aali309]

Yes, the if condition looks correct and should not be false. I was hoping it was a typo because I do that a lot. I checked the code and the updated parts looks ok. I tried removing the owner part on the if statement, it works well on my local main. But then the build-and-test previously also had the if: github.repository.owner == 'cryostatio' and it worked fine. I am still looking.

[aali309]

This does not look right. we should have two jobs here. build-and-test java 17 and build-and-test java 21

like so?

[aali309]

if: github.repository.owner == 'cryostatio' -> if: github.repository_owner == 'cryostatio'
This is the reason

[andrewazores]

That could be a red herring - maybe it doesn't get fully evaluated since it's from a matrix workflow that was entirely skipped because its dependencies were skipped.

[andrewazores]

if: github.repository.owner == 'cryostatio' -> if: github.repository_owner == 'cryostatio' This is the reason

Ah, nice find!

[andrewazores]

/build_test

[github-actions]

Workflow started at 11/9/2023, 11:22:57 AM. View Actions Run.

[github-actions]

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6814570092

[github-actions]

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6814570092

[lkonno]

This solution creating an extension to call the methods is much better and it will be easier to apply to the the other tests.