fix(rules): rule application occurs within DB transaction to ensure cursor is not closed prematurely #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build_test |
|
Workflow started at 1/18/2024, 4:20:42 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
1 similar comment
|
CI build and push: All tests pass ✅ |
andrewazores
force-pushed
the
rule-transaction
branch
from
692f9a6 to
e88721a
Compare
…ursor is not closed prematurely
andrewazores
force-pushed
the
rule-transaction
branch
from
e88721a to
80e7374
Compare
|
/build_test |
|
Workflow started at 1/19/2024, 3:13:06 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
1 similar comment
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #245
Description of the change:
Annotate method with
@Transactionalto ensure the database cursor/connection is not prematurely closed.Motivation for the change:
See #245
How to manually test:
See #245
Also try:
{ "name": "test", "description": "", "matchExpression": "!target.connectUrl.startsWith('http')", "eventSpecifier": "template=Profiling,type=TARGET", "archivalPeriodSeconds": 15, "initialDelaySeconds": 0, "preservedArchives": 3, "maxAgeSeconds": 0, "maxSizeBytes": 10485760, "enabled": false, "recordingName": "auto_test" }Upload this rule definition and enable it. Recordings should be started within a few seconds, and then every 15 seconds afterward should be archived, and once there are 3 copies of each, the oldest copies should start rolling over and getting deleted.