fix(itest): fix GraphQLTest.java #395
Conversation
github-actions
bot
added
the
needs-triage
andrewazores
added
safe-to-test
and removed
needs-triage
aali309
force-pushed
the
GraphQLTest
branch
2 times, most recently
from
d363479 to
4b532b9
Compare
aali309
force-pushed
the
GraphQLTest
branch
4 times, most recently
from
e9b4de4 to
3019caa
Compare
aali309
force-pushed
the
GraphQLTest
branch
3 times, most recently
from
785e520 to
b0d7704
Compare
aali309
force-pushed
the
GraphQLTest
branch
3 times, most recently
from
03b1dff to
fbc5b87
Compare
|
/build_test |
|
Workflow started at 6/24/2024, 2:18:20 PM. View Actions Run. |
|
OpenAPI schema change detected: diff --git a/schema/openapi.yaml b/schema/openapi.yaml
index ae4c70b..0456528 100644
--- a/schema/openapi.yaml
+++ b/schema/openapi.yaml
@@ -55,20 +55,24 @@ components:
type: array
type: object
Data:
type: object
DiscoveryNode:
properties:
children:
items:
$ref: '#/components/schemas/DiscoveryNode'
type: array
+ descendantTargets:
+ items:
+ $ref: '#/components/schemas/DiscoveryNode'
+ type: array
id:
format: int64
type: integer
labels:
additionalProperties:
type: string
type: object
name:
pattern: \S
type: string
|
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
src/test/java/itest/GraphQLTest.java
Outdated
| @@ -18,9 +18,13 @@ | |||
| import static org.hamcrest.MatcherAssert.assertThat; | |||
| import static org.hamcrest.Matchers.hasItem; | |||
| import static org.hamcrest.Matchers.is; | |||
| import static org.mockito.ArgumentMatchers.*; | |||
| import static org.mockito.Mockito.*; | |||
There was a problem hiding this comment.
Could you replace these start-imports with explicit imports for whichever classes and static methods are used?
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request blocked. webui submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the webui submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.
There was a problem hiding this comment.
Pull Request blocked. webui submodule updates are performed automatically by CI when that repository is updated. Please revert or drop all changes to the webui submodule from this PR and perform any required frontend work by opening and merging a PR against cryostat-web.
|
/build_test |
|
Workflow started at 6/26/2024, 11:45:48 AM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
Co-authored-by: Andrew Azores <[email protected]> (cherry picked from commit c5ea2a3)
fix(itest): fix GraphQLTest.java (#395) Co-authored-by: Andrew Azores <[email protected]> (cherry picked from commit c5ea2a3) Co-authored-by: Atif Ali <[email protected]>
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainBased on: #294
Continuation of: #316
Description of the change:
This change allows an environment variable to be configured so that...
Motivation for the change:
This change is helpful because users may want to...
How to manually test: