Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoketest): use relative ext redirect URLs #505

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


See cryostatio/cryostat-operator#874

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jun 7, 2024
@andrewazores andrewazores requested review from aali309 and mwangggg June 7, 2024 17:48
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Jun 7, 2024
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 9c7f623 into cryostatio:main Jun 7, 2024
7 of 8 checks passed
@andrewazores andrewazores deleted the relative-ext-urls branch June 7, 2024 21:36
mergify bot pushed a commit that referenced this pull request Jun 7, 2024
andrewazores added a commit that referenced this pull request Jun 7, 2024
test(smoketest): use relative ext redirect URLs (#505)

(cherry picked from commit 9c7f623)

Co-authored-by: Andrew Azores <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants