Skip to content

Commit

Permalink
Problem: sim test fail on out of gas (#1156)
Browse files Browse the repository at this point in the history
* Problem: sim test fail on out of gas

* enlarge timeout

* clean up

* Revert "Problem: sim test fail on out of gas"

This reverts commit dfbf4fa.

* point to add of evm & feemarket sim state

* rm disable vesting

* Apply suggestions from code review

* update doc
  • Loading branch information
mmsqe authored Sep 7, 2023
1 parent 8510f18 commit 32e01be
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 12 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/sims.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
member:
name: Check whether it is triggered by team members with issue_comment or push or pull_request
runs-on: ubuntu-latest
timeout-minutes: 120
permissions:
pull-requests: write
if: >-
Expand Down Expand Up @@ -154,6 +153,7 @@ jobs:

test-sim-nondeterminism:
runs-on: ubuntu-latest
timeout-minutes: 120
needs: [build, install-runsim]
steps:
- uses: actions/setup-go@v3
Expand Down Expand Up @@ -209,6 +209,7 @@ jobs:

test-sim-import-export:
runs-on: ubuntu-latest
timeout-minutes: 120
needs: [build, install-runsim]
steps:
- uses: actions/setup-go@v3
Expand Down Expand Up @@ -264,6 +265,7 @@ jobs:

test-sim-after-import:
runs-on: ubuntu-latest
timeout-minutes: 120
needs: [build, install-runsim]
steps:
- uses: actions/setup-go@v3
Expand Down Expand Up @@ -319,6 +321,7 @@ jobs:

test-sim-multi-seed-short:
runs-on: ubuntu-latest
timeout-minutes: 120
needs: [build, install-runsim]
steps:
- uses: actions/setup-go@v3
Expand Down
2 changes: 0 additions & 2 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,6 @@ var (
allowedReceivingModAcc = map[string]bool{}
)

var _ servertypes.Application = (*App)(nil)

func init() {
userHomeDir, err := os.UserHomeDir()
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ replace (
// dgrijalva/jwt-go is deprecated and doesn't receive security updates.
// TODO: remove it: https://github.com/cosmos/cosmos-sdk/issues/13134
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
github.com/evmos/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20230906013646-05e6989e1891
github.com/evmos/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20230907031841-3eb35238cb95
// Fix upstream GHSA-h395-qcrw-5vmq and GHSA-3vp4-m3rf-835h vulnerabilities.
// TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,8 @@ github.com/crypto-org-chain/cometbft-db v0.0.0-20230412133340-ac70df4b45f6 h1:d4
github.com/crypto-org-chain/cometbft-db v0.0.0-20230412133340-ac70df4b45f6/go.mod h1:hF5aclS++7WrW8USOA3zPeKI0CuzwUD2TPYug25ANlQ=
github.com/crypto-org-chain/cosmos-sdk v0.46.0-beta2.0.20230905040840-b3af5590283b h1:d2GOFR3i3BjDlPsmJkp8Gsrt9LK2nq2IVEnE/rMv1Fo=
github.com/crypto-org-chain/cosmos-sdk v0.46.0-beta2.0.20230905040840-b3af5590283b/go.mod h1:EHwCeN9IXonsjKcjpS12MqeStdZvIdxt3VYXhus3G3c=
github.com/crypto-org-chain/ethermint v0.6.1-0.20230906013646-05e6989e1891 h1:14XAcN0XkU98IQniedQKZ+ns9njW3ihMQVemYMn36DM=
github.com/crypto-org-chain/ethermint v0.6.1-0.20230906013646-05e6989e1891/go.mod h1:mRvceZZ4cEJwG3km3uhHZ5PejeBsYujI5lhtSD0WToE=
github.com/crypto-org-chain/ethermint v0.6.1-0.20230907031841-3eb35238cb95 h1:rQzF790iJJ9s6WDWfCnwKyjiwe1/x2hFgECEPFCc5U4=
github.com/crypto-org-chain/ethermint v0.6.1-0.20230907031841-3eb35238cb95/go.mod h1:mRvceZZ4cEJwG3km3uhHZ5PejeBsYujI5lhtSD0WToE=
github.com/crypto-org-chain/gravity-bridge/module/v2 v2.0.1-0.20230825054824-75403cd90c6e h1:rSTc35OBjjCBx47rHPWBCIHNGPbMnEj8f7fNcK2TjVI=
github.com/crypto-org-chain/gravity-bridge/module/v2 v2.0.1-0.20230825054824-75403cd90c6e/go.mod h1:HBaDqlFjlaXJwVQtA7jHejyaA7xwjXI2o6pU/ccP3tE=
github.com/cyphar/filepath-securejoin v0.2.3/go.mod h1:aPGpWjXOXUn2NCNjFvBE6aRxGGx79pTxQpKOJNYHHl4=
Expand Down
4 changes: 2 additions & 2 deletions gomod2nix.toml
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ schema = 3
version = "v1.10.26"
hash = "sha256-gkMEwJ4rOgn12amD4QpZ4th/10uyTTeoFmpseuKDQPs="
[mod."github.com/evmos/ethermint"]
version = "v0.6.1-0.20230906013646-05e6989e1891"
hash = "sha256-a4TC0H+0VwmyZa+gcI7osc3De12DhPIey5u2RPPUavk="
version = "v0.6.1-0.20230907031841-3eb35238cb95"
hash = "sha256-Y98oAuDhU2OcfL8ZdsSrZO4NynZXWajdTjDlX1zkHfs="
replaced = "github.com/crypto-org-chain/ethermint"
[mod."github.com/felixge/httpsnoop"]
version = "v1.0.2"
Expand Down
6 changes: 2 additions & 4 deletions integration_tests/test_vesting.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

def test_create_account(cronos):
"""
test create vesting account tx works:
test create vesting account is disabled:
"""
cli = cronos.cosmos_cli()
src = "vesting"
Expand All @@ -17,6 +17,4 @@ def test_create_account(cronos):
end_time = int(time.time()) + 3000
fees = f"{fee}{denom}"
res = cli.create_vesting_account(addr, amt, end_time, from_="validator", fees=fees)
assert res["code"] == 0, res["raw_log"]
balance = cli.balance(addr, denom)
assert balance == amount
assert res["code"] == 18, res["raw_log"]

0 comments on commit 32e01be

Please sign in to comment.