Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: start with exported genesis is not tested #1140

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Aug 23, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Closes: #1138

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #1140 (412061f) into main (21ec1ad) will decrease coverage by 23.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1140       +/-   ##
===========================================
- Coverage   47.08%   24.08%   -23.01%     
===========================================
  Files          82       47       -35     
  Lines        7312     2940     -4372     
===========================================
- Hits         3443      708     -2735     
+ Misses       3503     2162     -1341     
+ Partials      366       70      -296     

see 50 files with indirect coverage changes

@mmsqe mmsqe marked this pull request as ready for review August 23, 2023 06:27
@mmsqe mmsqe requested a review from a team as a code owner August 23, 2023 06:27
@mmsqe mmsqe requested review from yihuang and leejw51crypto and removed request for a team August 23, 2023 06:27
@yihuang yihuang added this pull request to the merge queue Aug 23, 2023
Merged via the queue into crypto-org-chain:main with commit cc7f377 Aug 23, 2023
20 of 21 checks passed
yihuang pushed a commit that referenced this pull request Sep 7, 2023
…1139)

* add edit_ini_sections

* Problem: start with exported genesis is not tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: panic on importing valid genesis.json exported state.
2 participants