Problem: no log converted from native event #1159
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
===========================================
- Coverage 46.20% 33.57% -12.63%
===========================================
Files 108 113 +5
Lines 7975 11064 +3089
===========================================
+ Hits 3685 3715 +30
- Misses 3923 6980 +3057
- Partials 367 369 +2
|
mmsqe
force-pushed
the
ref_relayer_event
branch
from
a321742
to
1c0d0b1
Compare
mmsqe
requested review from
leejw51crypto and
thomas-nguy
and removed request for
a team
mmsqe
force-pushed
the
ref_relayer_event
branch
from
de88542
to
12a97a2
Compare
| case strings.HasPrefix(addrString, cfg.GetBech32ValidatorAddrPrefix()): | ||
| addr, _ = sdk.ValAddressFromBech32(addrString) | ||
| case strings.HasPrefix(addrString, cfg.GetBech32AccountAddrPrefix()): | ||
| addr, _ = sdk.AccAddressFromBech32(addrString) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
| case common.IsHexAddress(addrString): | ||
| addr = common.HexToAddress(addrString).Bytes() | ||
| case strings.HasPrefix(addrString, cfg.GetBech32ValidatorAddrPrefix()): | ||
| addr, _ = sdk.ValAddressFromBech32(addrString) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack. Warning
| for _, event := range a.Events { | ||
| event_type := toUnderScore(event.Name) | ||
| descriptors[event_type] = &EventDescriptor{ | ||
| id: event.ID, | ||
| indexed: getArguments(event.Inputs, true), | ||
| nonIndexed: getArguments(event.Inputs, false), | ||
| packValues: event.Inputs.NonIndexed().PackValues, | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
| for _, event := range a.Events { | ||
| event_type := toUnderScore(event.Name) | ||
| descriptors[event_type] = &EventDescriptor{ | ||
| id: event.ID, | ||
| indexed: getArguments(event.Inputs, true), | ||
| nonIndexed: getArguments(event.Inputs, false), | ||
| packValues: event.Inputs.NonIndexed().PackValues, | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Signed-off-by: yihuang <[email protected]>
| @@ -180,7 +180,7 @@ | |||
| return nil, err | |||
| } | |||
|
|
|||
| logs, err := backend.TxLogsFromEvents(txResult.Events, parsedTx.MsgIndex) | |||
| logs, err := evmtypes.DecodeMsgLogsFromEvents(txResult.Data, parsedTx.MsgIndex, uint64(blockRes.Height)) | |||
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4f11310
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)