Problem: recent bug fixes are not included #1690
Conversation
mmsqe
requested review from
yihuang and
JayT106
and removed request for
a team
WalkthroughThe pull request updates the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1690 +/- ##
==========================================
- Coverage 16.87% 11.63% -5.25%
==========================================
Files 72 72
Lines 6163 6163
==========================================
- Hits 1040 717 -323
- Misses 5000 5395 +395
+ Partials 123 51 -72 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
go.mod (1)
Line range hint
3-3: Critical: Invalid Go version specifiedThe Go version
1.23.1does not exist (current latest is 1.22.0). This will cause build failures.Apply this diff to fix the Go version:
-go 1.23.1 +go 1.22.0
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)go.mod(1 hunks)
🔇 Additional comments (5)
go.mod (2)
Line range hint 5-54: Verify dependency compatibility and security
The dependencies are well-pinned to specific versions or commit hashes, which is good for reproducibility. However, let's verify there are no known vulnerabilities.
#!/bin/bash
# Description: Check for known vulnerabilities in direct dependencies
# Check for security advisories in key dependencies
for pkg in "github.com/ethereum/go-ethereum" "github.com/cosmos/cosmos-sdk" "github.com/cometbft/cometbft"; do
echo "Checking $pkg..."
gh api graphql -f query='{
securityVulnerabilities(first: 5, ecosystem: GO, package: "'$pkg'") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'
doneLine range hint 271-275: Verify local module replacements
The local module replacements need to be verified to ensure they exist and are properly structured.
#!/bin/bash
# Description: Verify local module replacements
# Check if the local modules exist and have go.mod files
for dir in "memiavl" "store" "versiondb"; do
echo "Checking $dir..."
if [ -d "$dir" ] && [ -f "$dir/go.mod" ]; then
echo "✓ $dir exists and has go.mod"
else
echo "✗ $dir is missing or incomplete"
fi
doneCHANGELOG.md (3)
Line range hint 1-1000: LGTM! The changelog structure is consistent.
The changelog follows a clear and consistent format with:
- Proper version sections with dates
- Categorized changes (Bug Fixes, Improvements, etc.)
- Referenced PR numbers and descriptions
Line range hint 12-13: Verify the improvement entries format and details.
The improvement entries follow the changelog format but should provide more context about:
- Why versiondb NewKVStore needed to accept string as store name
- The use cases and benefits of the new Timestamp API in versiondb iterator
#!/bin/bash
# Description: Verify the referenced PRs and their changes
# Check PR #1684 details
gh pr view 1684 --json title,body,commits,files
# Check PR #1688 details
gh pr view 1688 --json title,body,commits,files8-8: Verify the bug fix entry format and details.
The bug fix entry follows the changelog format but should provide more details about:
- The specific balance and gas price issues that were fixed
- The rationale for checking gasWanted only in checkTx mode
state machine breaking changelog update deps
yihuang
force-pushed
the
bump_ethermint
branch
from
e80afd4
to
cb16198
Compare
ce797fa
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
for more info
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Bug Fixes
Improvements
versiondbwith enhancements.versiondbiterator.Documentation
v1.4.0-rc3.