Fix OTR init message causing unknown command errors. #42
Conversation
…mmands. When OTR session is initiated by sending ?OTR? message, Unknown command errors are printed on Irssi status because only the first line gets sent as PRIVMSG and the human-readable HTML-formattad instruction message gets spit out as raw commands to the IRC server. This patch works around the problem by converting any line break characters (not allowed by IRC protocol) into spaces, thus also avoiding possible security issues with any other unexpected output from libotr even if this particular message string is fixed (like I intend to do in my next patch).
…ith a description customized for IRC and irssi-otr.
|
Hey thanks for this! I'll be looking into this pretty soon! Just wanted to ack your pull req. (and the two others). |
|
Any updates on this? There's also another fork called ahf-hax that looks interesting but unfortunately it is not based on mine and I have no time to properly review his work and do a merge. |
|
We are working with afh to get things polished and in addition, we're looking into the possibility of merging this into Irssi upstream. Stay tuned! |
|
@DrWhax i have been hearing about otr being merged in irssi upstream for a while now (your message is the oldest such utterance for me). so i don't think it should keep valid patches from being merged here, on the contrary: as long as the upstream otr module is not available, this here is the real thing that people use. i would go even further and say that improvements done on the irssi-otr native module should be merged here before the merge module is released. |
|
Did some syntax fixes in 251f7b8. Big thanks! |
|
nice, thanks for the merge. |
Remove newline characters from libotr output and customize the OTR init message for IRC users.
Closes bug #33.