Skip to content

Commit

Permalink
remove outdated TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
overheadhunter committed May 10, 2024
1 parent 88a95eb commit c229fdd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions frontend/src/common/jwe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export class JWE {
return new EncryptedJWE(protectedHeader, [{ encrypted_key: encryptedKey, header: header }], iv, ciphertext, tag);
}

public static parseJson(jwe: JsonJWE): EncryptedJWE { // TODO: json:
public static parseJson(jwe: JsonJWE): EncryptedJWE {
if (!jwe.protected || !jwe.recipients || !jwe.iv || !jwe.ciphertext || !jwe.tag) {
throw new Error('Malformed JWE');
}
Expand Down Expand Up @@ -473,7 +473,6 @@ export class PBES2 {
public static readonly DEFAULT_ITERATION_COUNT = 1000000;
private static readonly NULL_BYTE = Uint8Array.of(0x00);

// TODO: can we dedup this with crypto.ts's PBKDF2? Or is the latter unused anyway, once we migrate all ciphertext to JWE containers
public static async deriveWrappingKey(password: string, alg: 'PBES2-HS512+A256KW' | 'PBES2-HS256+A128KW', salt: Uint8Array, iterations: number, extractable: boolean = false): Promise<CryptoKey> {
let hash, keyLen;
if (alg == 'PBES2-HS512+A256KW') {
Expand Down
2 changes: 1 addition & 1 deletion frontend/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
},
"ts-node": {
"compilerOptions": {
"module": "CommonJS" // TODO change to es2022?
"module": "CommonJS"
}
},
"include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.tsx", "src/**/*.vue"]
Expand Down

0 comments on commit c229fdd

Please sign in to comment.