Update appindicator based on JDK 22

[purejava]

Summary by CodeRabbit

• Chores
  • Updated Java version in GitHub Actions workflows for improved compatibility and performance.
• Refactor
  • Updated interface implementation in tray action callback for enhanced functionality.
  • Replaced GTK functions with new methods for tray icon and menu management, ensuring smoother operation and integration.

[coderabbitai]

Walkthrough

The updates primarily focus on modernizing the Java version used in GitHub Actions workflows and refining the integration with GTK for a Linux tray application. The shift from Java 21 to 22 ensures compatibility with the latest standards, while modifications in the application's code enhance its interaction with the operating system's graphical interface, making it more efficient and streamlined.

Changes

Files	Change Summary
.github/workflows/... (all workflow files)	Updated Java version from 21 to 22
src/main/java/org/cryptomator/linux/tray/ActionItemCallback.java	Changed implemented interface from GCallback to GCallback.Function
src/main/java/org/cryptomator/linux/tray/AppindicatorTrayMenuController.java	Replaced GTK functions with functions from purejava.appindicator package; updated AppIndicator method usage

🐇✨
In the realm of code, where Java beans sprout,
A version leap, a GTK shout.
From workflows to trays, changes take flight,
A rabbit hops through, basking in light.
🌟📦🛠️
"To Java 22," it cheerily brays,
Crafting the future, in luminous rays.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0410613 and a425083.

Files ignored due to path filters (1)

• pom.xml is excluded by: !**/*.xml

Files selected for processing (7)

• .github/workflows/build.yml (1 hunks)
• .github/workflows/codeql-analysis.yml (1 hunks)
• .github/workflows/dependency-check.yml (1 hunks)
• .github/workflows/publish-central.yml (1 hunks)
• .github/workflows/publish-github.yml (1 hunks)
• src/main/java/org/cryptomator/linux/tray/ActionItemCallback.java (1 hunks)
• src/main/java/org/cryptomator/linux/tray/AppindicatorTrayMenuController.java (4 hunks)

Files skipped from review due to trivial changes (2)

• .github/workflows/codeql-analysis.yml
• .github/workflows/dependency-check.yml

Additional comments: 7

src/main/java/org/cryptomator/linux/tray/ActionItemCallback.java (1)

• 8-8: The update from GCallback to GCallback.Function aligns well with JDK 22's emphasis on functional interfaces, enhancing type safety and clarity. This change is approved as it directly supports the PR's objectives.

.github/workflows/build.yml (1)

• 14-14: Updating the Java version to 22 in the GitHub Actions workflow is a necessary change to ensure compatibility with JDK 22. This update aligns with the PR objectives and is approved.

.github/workflows/publish-github.yml (1)

• 14-14: The update of the Java version to 22 in the GitHub Actions workflow for publishing to GitHub Packages is necessary for JDK 22 compatibility. This change is approved.

.github/workflows/publish-central.yml (1)

• 19-19: Updating the Java version to 22 in the GitHub Actions workflow for publishing to Maven Central is necessary for JDK 22 compatibility. This change is approved.

src/main/java/org/cryptomator/linux/tray/AppindicatorTrayMenuController.java (3)

• 13-24: The updates to use new GTK functions from the Gtk class and AppIndicator methods align with the PR objectives, enhancing the application's system tray integration on Linux. These changes are approved.
• 32-66: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [35-82]

The modifications in the initialization and manipulation of the tray icon and menu items, leveraging the updated Gtk and AppIndicator functionalities, support the application's compatibility with JDK 22 and improve its integration with the system tray on Linux platforms. These changes are approved.

• 94-113: The updates in handling ActionItem, SeparatorItem, and SubMenuItem for the tray menu, using the new GTK functions, enhance the application's usability and compatibility with the latest Java standards. These changes are approved.

[purejava]

Closes purejava/appindicator-gtk3-java#36

[infeo]

Thanks for the work, @purejava! (: