TrayMenuController API: Add support for active/inactive tray menu entries

[purejava]

Sets the "Lock All" entry in the tray menu insensitive, with all vaults being locked
Fixes cryptomator/cryptomator#3472

[coderabbitai]

Walkthrough

The recent update includes changes to the pom.xml and AppindicatorTrayMenuController.java files. The pom.xml file now references version 1.4.1 of appindicator. In AppindicatorTrayMenuController.java, the sensitivity of a GTK widget is dynamically set based on the enabled status of an ActionItem, aiming to address an issue where the "Lock All" option is shown even when all vaults are locked.

Changes

Files/Modules	Change Summary
pom.xml	Updated appindicator version from 1.4.0 to 1.4.1.
src/main/java/org/cryptomator/linux/tray/AppindicatorTrayMenuController.java	Adjusted GTK widget sensitivity based on the enabled() status of ActionItem.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AppindicatorTrayMenuController
    
    User ->> AppindicatorTrayMenuController: Clicks "Lock All"
    
    AppindicatorTrayMenuController -->> AppindicatorTrayMenuController: Check if any vaults are unlocked
    alt If any vaults are unlocked
        AppindicatorTrayMenuController -->> User: Enable "Lock All" option
    else If all vaults are locked
        AppindicatorTrayMenuController -->> User: Disable "Lock All" option
    end

Loading

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Remove "Lock All" option when all vaults are locked (#3472)	✅

Poem

A bunny in the code does roam,
With updates in the twilight's gloam,
"Lock All" now acts just right,
When vaults are locked, it's out of sight.
Bugs are squashed, the stars align,
CodeRabbit works, your software shines.
Sweet updates in the nick of time! 🌟🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7b72518 and cbe8c34.

Files selected for processing (2)

• pom.xml (1 hunks)
• src/main/java/org/cryptomator/linux/tray/AppindicatorTrayMenuController.java (1 hunks)

Files skipped from review due to trivial changes (1)

• pom.xml

Additional comments not posted (1)

src/main/java/org/cryptomator/linux/tray/AppindicatorTrayMenuController.java (1)

105-105: LGTM! The change correctly sets the sensitivity of the GTK widget.

The sensitivity of the menu item is now dynamically set based on the enabled() status of the ActionItem, aligning with the PR objective.

[infeo]

Thanks @purejava for the analysis and quick fix!