Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Refactor Validate Flags workflow #793

Conversation

straight-shoota
Copy link
Member

  • Check out the Crystal repo associated with the target branch (release/1.14 for release/1.14).
  • Run workflow only on ubuntu-latest. There's no reason to run this on different platforms. crystal tool flags operates on the raw source code and does not take platform differences into account.
  • Run workflow only when docs/syntax_and_semantics/compile_time_flags.md is changed to avoid noise in unrelated PRs

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for crystal-book ready!

Name Link
🔨 Latest commit bf7c2d3
🔍 Latest deploy log https://app.netlify.com/sites/crystal-book/deploys/672cc2160e56b70008175714
😎 Deploy Preview https://deploy-preview-793--crystal-book.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@straight-shoota straight-shoota changed the base branch from master to release/1.14 November 7, 2024 12:07
This reverts commit 96d1177.
@straight-shoota straight-shoota self-assigned this Nov 7, 2024
@straight-shoota straight-shoota merged commit 6ae7893 into crystal-lang:release/1.14 Nov 8, 2024
7 checks passed
@straight-shoota straight-shoota deleted the infra/refactor-validate-flags-job branch November 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants