Update distro inference strategy to handle dnf based systems #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Aug 6, 2024
ysbaddaden
approved these changes
Aug 13, 2024
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Dec 18, 2024
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@588099d This includes the following changes: * crystal-lang/distribution-scripts#339 * crystal-lang/distribution-scripts#335 * crystal-lang/distribution-scripts#334 * crystal-lang/distribution-scripts#269 * crystal-lang/distribution-scripts#332 * crystal-lang/distribution-scripts#329 * crystal-lang/distribution-scripts#327 * crystal-lang/distribution-scripts#324 * crystal-lang/distribution-scripts#323 * crystal-lang/distribution-scripts#325
straight-shoota
added a commit
to crystal-lang/crystal
that referenced
this pull request
Dec 20, 2024
Updates `distribution-scripts` dependency to crystal-lang/distribution-scripts@588099d This includes the following changes: * crystal-lang/distribution-scripts#339 * crystal-lang/distribution-scripts#335 * crystal-lang/distribution-scripts#334 * crystal-lang/distribution-scripts#269 * crystal-lang/distribution-scripts#332 * crystal-lang/distribution-scripts#329 * crystal-lang/distribution-scripts#327 * crystal-lang/distribution-scripts#324 * crystal-lang/distribution-scripts#323 * crystal-lang/distribution-scripts#325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #322.
Currently, the script isn't able to handle generic dnf distros. It is not uncommon for dnf systems to have yum as a symlink for the dnf executable, allowing the script to work by using the RHEL fallback, but for those who don't, the installation just fails.
This PR updates the distro detection strategy to handle generic dnf systems by adding Fedora Rawhide as a fallback if dnf is detected in an unknown distro.