Vendor lib/molinillo #663
Open
Vendor lib/molinillo #663
+2,783
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
approved these changes
Jan 16, 2025
With dependencies vendored in we don't need automatic dependency installation anymore. We can be sure that lib/ is always present. Upon dependency upgrade we'll need to explicitly run `shards update` but there's no reason to have a make recipe for that.
|
In an additional commit, I've removed the make recipes related to dependency installation. With dependencies vendored in we don't need automatic dependency installation anymore. We can be sure that lib/ is always present. Upon dependency upgrade we'll need to explicitly run |
ysbaddaden
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor the dependency code into the repository, as suggested in crystal-lang/crystal#15344 (comment). We're already doing the same in https://github.com/crystal-lang/crystal.
This simplifies the build process. All code required for building shards is contained in this repository (except for Crystal stdlib). There's no need to bootstrap the initial installation of the molinillo dependency anymore.