feat: add CLI commands for RPC URL and block number #1194
Conversation
|
|
WalkthroughThe latest update enhances the application by integrating new command-line options for specifying RPC URLs and block numbers. This enhancement not only broadens the configurability through the command line but also ensures that these settings can default to environment variables if not explicitly provided, offering a flexible and user-friendly approach to configuration management. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- src/Main.hs (4 hunks)
Additional comments: 4
src/Main.hs (4)
- 19-19: The addition of
Word64to the import list fromData.Wordis necessary for supporting the new--rpc-blockCLI argument, which expects a block number of typeWord64. This change is appropriate and ensures that the necessary types are available for handling the new functionality.- 136-137: The addition of
cliRpcUrlandcliRpcBlockto theOptionsdata type introduces new fields to store the values of the--rpc-urland--rpc-blockCLI arguments, respectively. This change is crucial for enabling the new functionality and allows these values to be passed through the application. The choice ofMaybe TextforcliRpcUrlandMaybe Word64forcliRpcBlockis appropriate, as it allows for the absence of these arguments, aligning with the described precedence of configuration settings.- 197-202: The update to the
optionsparser function to handle the--rpc-urland--rpc-blockarguments is implemented correctly. The use ofoptionaland the appropriate types (strfor--rpc-urlandautofor--rpc-block) ensures that these arguments are optional and parsed correctly. The help messages provided are clear and informative, guiding the user on how to use these new options.- 217-218: The modifications to the
overrideConfigfunction to prioritize CLI-provided values forrpcUrlandrpcBlockover environment variables and default configurations are implemented as described. The use of the<|>operator to select the first non-Nothingvalue among the CLI argument, environment variable, and existing configuration ensures that the precedence order is respected. This change effectively integrates the new CLI arguments into the application's configuration logic.
penandlim
force-pushed
the
addRpcConfigToCLI
branch
from
63cb249 to
61606d5
Compare
src/Main.hs
Outdated
| @@ -206,8 +214,8 @@ versionOption = infoOption | |||
|
|
|||
| overrideConfig :: EConfig -> Options -> IO EConfig | |||
| overrideConfig config Options{..} = do | |||
| rpcUrl <- Onchain.rpcUrlEnv | |||
| rpcBlock <- Onchain.rpcBlockEnv | |||
| rpcUrl <- (pure cliRpcUrl) <|> Onchain.rpcUrlEnv | |||
There was a problem hiding this comment.
This unfortunately won't work since <|> here operates on IO, not on Maybe. Can you rename rpcUrl to envRpcUrl (same for block) and change this instead: rpcUrl = cliRpcUrl <|> envRpcUrl <|> config.rpcUrl
There was a problem hiding this comment.
Updated. Thanks for the quick review!
Implemented CLI arguments
--rpc-urland--rpc-blockto allow overriding the corresponding environment variables.The precedence for settings is now: Command-Line Arguments > Environment Variables > Configuration Defaults.
Closes #1193
Summary by CodeRabbit