chore: add SPDX license identifiers for files missing them #59
+77
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xteddybear
requested review from
glarregay-tob,
bsamuels453,
montyly and
ggrieco-tob
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: we try to always treat compiler warnings as errors, to reliably catch some possible issues (such as not assigning to a return variable) as soon as possible, with foundry's
deny-warningssettingsolc, however, reports on a file not having anSPDXlicense identifier as error1878, which we have to manually ignore withignored_error_codes = [1878]This PR takes care of that, adding a SPDX license identifier to every source file missing it. I chose the same license as in the
LICENSEfile, without care for it's legality or consistency, and didn't modify the license identifier of files having one (which includesUnlicenseandMIT)