allow dead code to not have an immediate dominator #1982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montyly
reviewed
Jun 22, 2023
| @@ -95,5 +95,4 @@ def compute_dominance_frontier(nodes: List["Node"]) -> None: | |||
| runner.dominance_frontier = runner.dominance_frontier.union({node}) | |||
| while runner != node.immediate_dominator: | |||
| runner.dominance_frontier = runner.dominance_frontier.union({node}) | |||
| assert runner.immediate_dominator | |||
There was a problem hiding this comment.
For the sake of the type annotation, should we do a break if the immediate dominator is none?
This will also allow us to add a code comment regarding the dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example in the issue highlights that the expression
i++will cause issues since it is dead code and thus does not have any dominating nodescloses #1973