-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for 08d631f #2460
add test for 08d631f #2460
Conversation
WalkthroughWalkthroughThe changes involve adding a new function Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (7)
tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.10-compact.zip
is excluded by!**/*.zip
tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.11-compact.zip
is excluded by!**/*.zip
tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.12-compact.zip
is excluded by!**/*.zip
tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.13-compact.zip
is excluded by!**/*.zip
tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.14-compact.zip
is excluded by!**/*.zip
tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.15-compact.zip
is excluded by!**/*.zip
tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.8-compact.zip
is excluded by!**/*.zip
Files selected for processing (8)
- tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.10-compact.json (1 hunks)
- tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.11-compact.json (1 hunks)
- tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.12-compact.json (1 hunks)
- tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.13-compact.json (1 hunks)
- tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.14-compact.json (1 hunks)
- tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.15-compact.json (1 hunks)
- tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.8-compact.json (1 hunks)
- tests/e2e/solc_parsing/test_data/user_defined_value_type/abi-decode-fixed-array.sol (2 hunks)
Additional comments not posted (9)
tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.10-compact.json (1)
6-6
: The addition oftest_decode_struct_array(bytes)
is consistent with the PR objectives and is correctly formatted in the JSON structure.tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.11-compact.json (1)
6-6
: The addition oftest_decode_struct_array(bytes)
is consistent with the PR objectives and is correctly formatted in the JSON structure.tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.12-compact.json (1)
6-6
: The addition oftest_decode_struct_array(bytes)
is consistent with the PR objectives and is correctly formatted in the JSON structure.tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.13-compact.json (1)
6-6
: The addition oftest_decode_struct_array(bytes)
is consistent with the PR objectives and is correctly formatted in the JSON structure.tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.14-compact.json (1)
6-6
: The addition oftest_decode_struct_array(bytes)
is consistent with the PR objectives and is correctly formatted in the JSON structure.tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.15-compact.json (1)
6-6
: The addition oftest_decode_struct_array(bytes)
is consistent with the PR objectives and is correctly formatted in the JSON structure.tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.8-compact.json (1)
6-6
: The addition oftest_decode_struct_array(bytes)
is consistent with the PR objectives and is correctly formatted in the JSON structure.tests/e2e/solc_parsing/test_data/user_defined_value_type/abi-decode-fixed-array.sol (2)
3-3
: The addition of the structS
is consistent with the PR objectives and is correctly defined.
17-19
: The addition oftest_decode_struct_array(bytes)
is consistent with the PR objectives and is correctly implemented in Solidity.
closes #586
Summary by CodeRabbit
abi-decode-fixed-array.sol
file.struct
typeS
with auint256
field in the contractC
.test_decode_interface_array
andtest_decode_struct_array
to decode arrays of interfaces and structs respectively.