Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for 08d631f #2460

Merged
merged 1 commit into from
May 17, 2024
Merged

add test for 08d631f #2460

merged 1 commit into from
May 17, 2024

Conversation

0xalpharush
Copy link
Contributor

@0xalpharush 0xalpharush commented May 17, 2024

closes #586

Summary by CodeRabbit

  • New Features
    • Added functionality to decode struct arrays in various versions of the abi-decode-fixed-array.sol file.
    • Introduced a new struct type S with a uint256 field in the contract C.
    • Added new functions test_decode_interface_array and test_decode_struct_array to decode arrays of interfaces and structs respectively.

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

Walkthrough

The changes involve adding a new function test_decode_struct_array(bytes) to the C class in multiple versions of the abi-decode-fixed-array.sol file. This function is designed to decode a struct array and is added alongside existing functions that decode interface and enum arrays.

Changes

Files Change Summary
tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.10-compact.json
tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.11-compact.json
tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.12-compact.json
tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.14-compact.json
Added test_decode_struct_array(bytes) function to the C class to decode struct arrays alongside existing functions.
tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.13-compact.json
tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.15-compact.json
Added test_decode_struct_array(bytes) function to the C class for decoding struct arrays.
tests/e2e/solc_parsing/test_data/user_defined_value_type/abi-decode-fixed-array.sol Added a new struct S {uint256 a;} and functions test_decode_interface_array and test_decode_struct_array to contract C.

Assessment against linked issues

Objective Addressed Explanation
Handle parsing expression indexing into a struct type (586)
Ensure no exceptions are thrown when accessing struct elements through indexing (586)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0xalpharush 0xalpharush marked this pull request as ready for review May 17, 2024 20:57
@0xalpharush 0xalpharush merged commit aed5927 into dev May 17, 2024
79 checks passed
@0xalpharush 0xalpharush deleted the test/abi-decode-array-of-structs branch May 17, 2024 20:59
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 5793b0d and 4f661e4.
Files ignored due to path filters (7)
  • tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.10-compact.zip is excluded by !**/*.zip
  • tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.11-compact.zip is excluded by !**/*.zip
  • tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.12-compact.zip is excluded by !**/*.zip
  • tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.13-compact.zip is excluded by !**/*.zip
  • tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.14-compact.zip is excluded by !**/*.zip
  • tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.15-compact.zip is excluded by !**/*.zip
  • tests/e2e/solc_parsing/test_data/compile/user_defined_value_type/abi-decode-fixed-array.sol-0.8.8-compact.zip is excluded by !**/*.zip
Files selected for processing (8)
  • tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.10-compact.json (1 hunks)
  • tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.11-compact.json (1 hunks)
  • tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.12-compact.json (1 hunks)
  • tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.13-compact.json (1 hunks)
  • tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.14-compact.json (1 hunks)
  • tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.15-compact.json (1 hunks)
  • tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.8-compact.json (1 hunks)
  • tests/e2e/solc_parsing/test_data/user_defined_value_type/abi-decode-fixed-array.sol (2 hunks)
Additional comments not posted (9)
tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.10-compact.json (1)

6-6: The addition of test_decode_struct_array(bytes) is consistent with the PR objectives and is correctly formatted in the JSON structure.

tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.11-compact.json (1)

6-6: The addition of test_decode_struct_array(bytes) is consistent with the PR objectives and is correctly formatted in the JSON structure.

tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.12-compact.json (1)

6-6: The addition of test_decode_struct_array(bytes) is consistent with the PR objectives and is correctly formatted in the JSON structure.

tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.13-compact.json (1)

6-6: The addition of test_decode_struct_array(bytes) is consistent with the PR objectives and is correctly formatted in the JSON structure.

tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.14-compact.json (1)

6-6: The addition of test_decode_struct_array(bytes) is consistent with the PR objectives and is correctly formatted in the JSON structure.

tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.15-compact.json (1)

6-6: The addition of test_decode_struct_array(bytes) is consistent with the PR objectives and is correctly formatted in the JSON structure.

tests/e2e/solc_parsing/test_data/expected/user_defined_value_type/abi-decode-fixed-array.sol-0.8.8-compact.json (1)

6-6: The addition of test_decode_struct_array(bytes) is consistent with the PR objectives and is correctly formatted in the JSON structure.

tests/e2e/solc_parsing/test_data/user_defined_value_type/abi-decode-fixed-array.sol (2)

3-3: The addition of the struct S is consistent with the PR objectives and is correctly defined.


17-19: The addition of test_decode_struct_array(bytes) is consistent with the PR objectives and is correctly implemented in Solidity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant