Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapters/compute: Fix links to images #126

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

teodutu
Copy link

@teodutu teodutu commented Nov 4, 2024

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

Change links to <subchapter-name/media/image-name> to fit the new layout created by #95.

Change links to `<subchapter-name/media/image-name>` to fit the new layout
created by open-education-hub#95.

Signed-off-by: Teodor Dutu <[email protected]>
@teodutu teodutu added the needs-rendering The PR makes changes to the website that need to be rendered label Nov 4, 2024
@teodutu teodutu self-assigned this Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

@teodutu
Copy link
Author

teodutu commented Nov 4, 2024

Links to generated-media such as those [1] are still not modified. @Alex-deVis, does gen_view.py account for the GIFs we create from .svg images using ffmpeg?

[1]

![Round-Robin Scheduling](../generated-media/round-robin-generated.gif)

@Alex-deVis
Copy link

I opened a PR #127 for this without fully checking your changes. Either merge both, or just take the Makefile changes from mine.

@teodutu teodutu merged commit 5436a03 into cs-pub-ro:main Nov 4, 2024
4 checks passed
@teodutu teodutu deleted the fix-compute-slides-links branch November 4, 2024 19:56
teodutu added a commit that referenced this pull request Nov 4, 2024
PR #126 missed 2 links to images in the Compute chapter that are still
broken. This commit fixes them.

Signed-off-by: Teodor Dutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rendering The PR makes changes to the website that need to be rendered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants