Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asg/parallel-graph: Update assignment #30

Merged
merged 6 commits into from
Nov 20, 2023

Conversation

razvand
Copy link

@razvand razvand commented Nov 20, 2023

Make overhaul update of the assignment: skeleton implementation, README, Makefiles.

@razvand razvand requested a review from StefanJum November 20, 2023 06:27
@razvand razvand force-pushed the razvand/asg/update-parallel-graph branch from edbb947 to 50bdada Compare November 20, 2023 06:45
@Alex-deVis Alex-deVis added needs-rendering The PR makes changes to the website that need to be rendered area/assignment Update to homework assignments topic/compute Related to "Compute" chapter labels Nov 20, 2023
Copy link

content/assignments/parallel-graph/README.md Outdated Show resolved Hide resolved
content/assignments/parallel-graph/README.md Outdated Show resolved Hide resolved
content/assignments/parallel-graph/README.md Outdated Show resolved Hide resolved
content/assignments/parallel-graph/README.md Outdated Show resolved Hide resolved
content/assignments/parallel-graph/README.md Outdated Show resolved Hide resolved
content/assignments/parallel-graph/README.md Outdated Show resolved Hide resolved
@razvand razvand force-pushed the razvand/asg/update-parallel-graph branch from 50bdada to b3f9063 Compare November 20, 2023 08:38
@razvand razvand requested a review from Alex-deVis November 20, 2023 08:39
Improve wording. Add detailed information on checking and grading,
similar to the other assignments.

Signed-off-by: Razvan Deaconescu <[email protected]>
Simplify Makefile in `tests/` to the required bits for testing the
assignment.

Signed-off-by: Razvan Deaconescu <[email protected]>
Add `utils/` directory with utilities files as symlinks. They are used
for logging and ending the program.

Signed-off-by: Razvan Deaconescu <[email protected]>
The include path is used to point to the utils directory included in
source code files.

Signed-off-by: Razvan Deaconescu <[email protected]>
Synchronize skeleton implementation with the official soluion. The
official solution is a redesign of the thread pool, together with the
use of a generic list implementation (inspired from the Linux kernel).

Signed-off-by: Razvan Deaconescu <[email protected]>
Update README.md to the new skeleton contents, based on the update
implementation of the thread pool.

Signed-off-by: Razvan Deaconescu <[email protected]>
@razvand razvand force-pushed the razvand/asg/update-parallel-graph branch from b3f9063 to 2b7fa34 Compare November 20, 2023 09:05
Copy link

@Alex-deVis Alex-deVis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@razvand razvand merged commit 1921940 into cs-pub-ro:main Nov 20, 2023
1 of 3 checks passed
@razvand razvand deleted the razvand/asg/update-parallel-graph branch November 20, 2023 09:16
@gabrielmocanu gabrielmocanu added needs-rendering The PR makes changes to the website that need to be rendered and removed needs-rendering The PR makes changes to the website that need to be rendered labels Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/assignment Update to homework assignments needs-rendering The PR makes changes to the website that need to be rendered topic/compute Related to "Compute" chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants