-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general/drills: Add "Distributed system" written task as exam #54
Conversation
Published at https://cs-pub-ro.github.io/operating-systems/54/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address my inline comments and then:
- Set your email properly as explained here [1]. It appears weird in your commit signatures:
Signed-off-by: Petru-Vlad Ionescu <[email protected]>
- Squash your commits into a single one using
git rebase -i main
. This will open your default editor and you'll see your 3 commits. Leave the first line unchanged, then replace the word "pick" with "s" (from "squash") in the other 2 lines. Then a new menu will open where you'll be able to reword your commit message. Edit it as you wish. When making further changes, justgit commit --amend --no-edit
to add them to the already existing last commit and thengit push -f
to overwrite it remotely. This way you'll keep this PR as 1 commit.
[1] https://github.com/cs-pub-ro/operating-systems/blob/main/CONTRIBUTING.md#commits
4f55938
to
25bbf75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content is good. Before we merge this, set your email address on GitHub so that it matches the one in the commit signature. After that, run git commit --amend --no-edit
to update the commit with no additional changes and git push -f
to re-trigger the CI/CD. Otherwise checkpatch fails: https://github.com/cs-pub-ro/operating-systems/actions/runs/8221132857/job/22481137592?pr=54#step:3:568
25bbf75
to
fa91be2
Compare
general/drills: Modified contents of distributed-system.md and config.yaml Signed-off-by: Petru-Vlad Ionescu <[email protected]>
fa91be2
to
5da2462
Compare
Prerequisite Checklist
Description of changes