Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general/drills: Add "Distributed system" written task as exam #54

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

vladiouz
Copy link

@vladiouz vladiouz commented Mar 5, 2024

Prerequisite Checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Updated relevant documentation (if needed).

Description of changes

@vladiouz vladiouz requested a review from teodutu March 5, 2024 19:33
@vladiouz vladiouz self-assigned this Mar 5, 2024
@github-actions github-actions bot added topic/general Related to multiple chapters kind/improve Improve / Update existing content / item kind/new New content / item labels Mar 6, 2024
@teodutu teodutu added the needs-rendering The PR makes changes to the website that need to be rendered label Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address my inline comments and then:

  • Set your email properly as explained here [1]. It appears weird in your commit signatures: Signed-off-by: Petru-Vlad Ionescu <[email protected]>
  • Squash your commits into a single one using git rebase -i main. This will open your default editor and you'll see your 3 commits. Leave the first line unchanged, then replace the word "pick" with "s" (from "squash") in the other 2 lines. Then a new menu will open where you'll be able to reword your commit message. Edit it as you wish. When making further changes, just git commit --amend --no-edit to add them to the already existing last commit and then git push -f to overwrite it remotely. This way you'll keep this PR as 1 commit.

[1] https://github.com/cs-pub-ro/operating-systems/blob/main/CONTRIBUTING.md#commits

chapters/general/drills/tasks/distributed-system.md Outdated Show resolved Hide resolved
chapters/general/drills/tasks/distributed-system.md Outdated Show resolved Hide resolved
@vladiouz vladiouz force-pushed the add-distributed-system-exam branch from 4f55938 to 25bbf75 Compare March 10, 2024 09:57
Copy link

@teodutu teodutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is good. Before we merge this, set your email address on GitHub so that it matches the one in the commit signature. After that, run git commit --amend --no-edit to update the commit with no additional changes and git push -f to re-trigger the CI/CD. Otherwise checkpatch fails: https://github.com/cs-pub-ro/operating-systems/actions/runs/8221132857/job/22481137592?pr=54#step:3:568

@vladiouz vladiouz force-pushed the add-distributed-system-exam branch from 25bbf75 to fa91be2 Compare March 12, 2024 23:23
general/drills: Modified contents of distributed-system.md and config.yaml

Signed-off-by: Petru-Vlad Ionescu <[email protected]>
@vladiouz vladiouz force-pushed the add-distributed-system-exam branch from fa91be2 to 5da2462 Compare March 12, 2024 23:49
@vladiouz vladiouz merged commit 9b8b4cd into cs-pub-ro:main Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improve Improve / Update existing content / item kind/new New content / item needs-rendering The PR makes changes to the website that need to be rendered topic/general Related to multiple chapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants