Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Remove 'make deps' from README instructions #3991

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

phil-davis
Copy link
Contributor

phil@phil-Inspiron-5468:~/git/cs3org/reva$ make deps
make: *** No rule to make target 'deps'.  Stop.

I am trying to follow the instructions to run a local reva from the edge branch.

The first thing is that the deps Makefile target does not exist.

I suppose that it used to exist. Is there something different that we are supposed to do?

Maybe there is documentation elsewhere, and the README should be updated to link to the correct up-to-date docs for building and running the edge branch locally.

@phil-davis phil-davis self-assigned this Jun 19, 2023
@phil-davis phil-davis changed the title Remove 'make deps' from README instructions tests-only] Remove 'make deps' from README instructions Jun 19, 2023
@phil-davis phil-davis force-pushed the make-deps-does-not-exist branch from eb662cc to 656da76 Compare June 19, 2023 11:04
@cs3org cs3org deleted a comment from update-docs bot Jun 19, 2023
@phil-davis phil-davis changed the title tests-only] Remove 'make deps' from README instructions [tests-only] Remove 'make deps' from README instructions Jun 19, 2023
@phil-davis phil-davis force-pushed the make-deps-does-not-exist branch from 656da76 to b0cb511 Compare June 19, 2023 11:05
@jnweiger
Copy link

jnweiger commented Apr 24, 2024

Second that. make deps is still mentioned in the README.md, but it was removed from the Makefile in commit 8f3ab78

I can happily run make build-reva and reva/toolchain/goimports appears and collects a nice list of dependencies.
Can we please merge this simple fix?

@phil-davis phil-davis requested review from individual-it and removed request for ishank011 April 25, 2024 04:04
@phil-davis phil-davis force-pushed the make-deps-does-not-exist branch from b0cb511 to b5bb24d Compare July 9, 2024 08:31
@phil-davis
Copy link
Contributor Author

@micbar can you please approve, and we can merge. That will get rid of a tiny PR from the list here in reva.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants