Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository #26

Merged
merged 41 commits into from
Jan 29, 2024
Merged

Update repository #26

merged 41 commits into from
Jan 29, 2024

Conversation

mcflugen
Copy link
Member

@mcflugen mcflugen commented Jan 27, 2024

This pull request updates the model_metadata repository for Python 3.12, cleans up a lot of code, and removes a lot of unused code.

Given the large number of changes, I think this will require a bump in the package's major version. I take it back. I'm not ready to commit to no breaking changes.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7679898959

  • -159 of 625 (74.56%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+72.8%) to 72.759%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model_metadata/load.py 25 26 96.15%
src/model_metadata/modelmetadata.py 52 55 94.55%
src/model_metadata/main.py 0 4 0.0%
src/model_metadata/find.py 10 14 71.43%
src/model_metadata/model_info.py 37 47 78.72%
src/model_metadata/model_data_files.py 17 29 58.62%
src/model_metadata/model_setup.py 38 68 55.88%
src/model_metadata/main.py 103 138 74.64%
src/model_metadata/model_parameter.py 159 219 72.6%
Totals Coverage Status
Change from base Build 710659086: 72.8%
Covered Lines: 633
Relevant Lines: 870

💛 - Coveralls

@mcflugen mcflugen merged commit 5278180 into main Jan 29, 2024
13 checks passed
@mcflugen mcflugen deleted the mcflugen/update-repository branch January 29, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants