Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Spanish support to README.md intro #344

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds Spanish support to README.md intro #344

wants to merge 1 commit into from

Conversation

ryienh
Copy link

@ryienh ryienh commented Oct 21, 2019

This adds Spanish support to the README introduction, which gives an overview about the goals and implementation of the project

@westbl westbl requested review from bradjc and ppannuto December 26, 2019 21:12
@ppannuto
Copy link
Contributor

This looks good, but I'm concerned that the README will balloon pretty spectacularly if we keep adding more languages. After a somewhat dissatisfying google session, it seems the consensus solution to this problem is to leave the top level README.md in English, then add additional README.es.md and etc files with translations.

Can you make that refactor? Otherwise, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants