Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jss-plugin-expand): Add support background array of objects #1659

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

N1cE-me
Copy link

@N1cE-me N1cE-me commented Aug 12, 2024

Corresponding Issue(s): #711

What Would You Like to Add/Fix?

Support for multiple backgrounds list, from array of objects. Example:

[
  {
    "image": "url(...)",
    "position": ["50%", "50%"],
    "size": "cover",
    "repeat": "no-repeat"
  },
  {
    "image": "linear-gradient(....)"
  },
  {
    "image": "url(...)",
    "position": [0, 0],
    "size": "cover"
  },
]

Expectations on Changes

This changes only add support for arrays. Old code will still work without the need to make changes.

@N1cE-me N1cE-me requested a review from kof as a code owner August 12, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant