-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for array-event-wise aggregation of dl1 image parameters #2497
Open
LukasBeiske
wants to merge
15
commits into
main
Choose a base branch
from
feature_aggregator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
14a7638
Add component for aggregating dl1 features
LukasBeiske 4874ce4
Refactor numpy vectorization functions into own module
LukasBeiske 81f6104
Add dl1 aggregates to io; add separete tool; add it to ctapipe-process
LukasBeiske d7b8650
Add changelog
LukasBeiske 7072b10
Add BaseStatisticsContainer to __all__
LukasBeiske c49cd53
Add module docstrings; do not overwrite python built-ins
LukasBeiske 07c3bda
Update TableLoader
LukasBeiske 679fc60
Update DataWriter
LukasBeiske 4a442dc
Move collect_features into vectorization module
LukasBeiske b7d4c9f
Add numba function to replace np.unique and other optimization of vec…
LukasBeiske 43cb241
Iterate over dl1 tels not tels_with_trigger
LukasBeiske 7f258fc
Add tests
LukasBeiske df268de
Move error for empty image_parameters trait into FeatureAggregator
LukasBeiske 65791a6
Add additional test for process tool
LukasBeiske 16f184e
Fix typos
LukasBeiske File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Add the ``FeatureAggregator`` component and the ``ctapipe-aggregate-image-parameters`` tool | ||
for aggregating the telescope-wise dl1 image parameters for each array event. | ||
This functionality is also added to ``ctapipe-process``. | ||
|
||
Refactor helper functions for vectorized numpy calculations into new ``ctapipe.vectorization`` module. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible I missed it, but you are collecting features from all telescope in the event, but shouldn't it include only those used in reconstruction? In other words, instead of
tels_with_trigger
, you should have something likeevent.dl2.stereo.geometry.telescopes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now this is done via a quality query in
aggregate_table
, which should use the same quality criteria as the reconstruction for which the error will be estimated. But if this is integrated into the train/apply tool for the error estimator, doing it that way would be better, I agree.