Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notifications page and integrated with backend #27

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

ctc-devops
Copy link
Contributor

@ctc-devops ctc-devops commented Jan 25, 2024

Authors:

What does this PR contain?

  • on /notifications page, we added a table that lists out all the pending users with functionality to approve/decline
  • in table header, there is the ability to approve all or decline all
  • note: for some reason, when you sign up for an account, it takes you to the landing dashboard page. so you are able to access the /notification page. i think this is not right. however, when you log out and signin again, then you are prompted with "pending approval" and can't log in until you are approved. i don't think our code affect that (maybe it's a bug in auth redirect?). everything else works as normal (ex: if you decline all from the notification's page and you are signed in as the pending user, then you are kicked out to login page).

How did you test these changes?

pgadmin

Attach images (if applicable)

Closes #21

@ThatMegamind ThatMegamind linked an issue Feb 4, 2024 that may be closed by this pull request
Copy link
Collaborator

@ThatMegamind ThatMegamind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to us! (TLs + shadowees)

@ThatMegamind ThatMegamind merged commit 4455cd7 into dev Feb 4, 2024
2 of 3 checks passed
@ThatMegamind ThatMegamind deleted the 21-notifications-page-and-integrate-w-backend branch February 4, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications Page (Frontend) and Integrate w/ Backend
5 participants