#23 Create endpoints 4 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for working around the issues of the users file! Todo for TLs: |
theNatePi
requested changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created endpoints for the Users table
Screenshots/Media
Issues
Closes #23
Additional Notes
There was already a users.ts in the same folder where the endpoints are supposed to go that does CRUD for users based on the firebaseUid rather than id. I was running into problems as a result of this same file name in the src/app.ts because I think the TypeScript file was overshadowing the JavaScript one. To make the TypeScript and JavaScript file differentiable, I made our file name "user.js" (no "s" at the end like the TypeScript file), the route is "/users", and the router is usersRouter. Let me know if you guys need me to change this :D