Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Home Page Bug Fix + Happening Now Tag #195

Merged
merged 8 commits into from
May 15, 2024

Conversation

brelieu05
Copy link
Collaborator

Authors:
brelieu05, jessieh9

What does this PR contain?
Admin Home Page Bug Fix + Happening Now Tag

How did you test these changes?
Made new event and checked if new tag was there and pressed on event and checked redirection.

Closes #188

@brelieu05 brelieu05 linked an issue May 3, 2024 that may be closed by this pull request
@brelieu05 brelieu05 requested a review from NwinNwin May 3, 2024 23:50
Copy link
Collaborator

@NwinNwin NwinNwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! It looks like the Edit Modal in both the CheckinPage and InputDataPage isn't functioning properly. Here are some specific issues you've noticed:

  • The editing event functionality is not working. When you try to change values in the Edit Modal, these changes are not reflected in the data.

  • The start and end times remain the same even after you attempt to change them.

    Acceptance Criteria:

    • Working Edit Modal 🤓 👍

@brelieu05
Copy link
Collaborator Author

brelieu05 commented May 14, 2024

putEvent doesn't update the backend, even if its provided with an updated eventData with the changed start_time and end_time. putEvent also returns status 200 even though nothing changed.

I don't think its a formatting issue since we tried having the times in the HH:mm format and the backend time format HH:mm:ss+ss. Also tried doing setEventData(...eventData, start_time: time) vs setEventData(...eventData, startTime: time), but no difference, and a bunch of other things.

This is the payload or eventData being passed into the PUT request
image

This is the response given back which is the event unchanged
image

@NwinNwin NwinNwin merged commit 5605a53 into main May 15, 2024
1 of 2 checks passed
@NwinNwin NwinNwin deleted the 188-admin-home-page-bug-fix-+-happening-now-tag branch May 15, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Home Page Bug Fix + Happening Now Tag
3 participants