Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

News Posts #39

Merged
merged 30 commits into from
Feb 6, 2024
Merged

News Posts #39

merged 30 commits into from
Feb 6, 2024

Conversation

GAsplund
Copy link
Member

@GAsplund GAsplund commented Jan 26, 2024 •
edited
Loading

Key Features

  • CRUD for basic news posts
  • Markdown rendering
  • Permission checks for creating, updating and deleting posts
  • Add CSS file for defining lengths and dimensions for reuse
  • Remove default Next.JS page and set new default font
  • Include user CID in session
  • Add new service for fetching (currently) news-related information about a user's session

Known Issues

  • Design is not yet finished
  • Attempting to post as division groups that don't exist in the database will return an error and not create a post
  • Multiple line breaks get squished into one (maybe not an issue?)

Preview

image
image

GAsplund and others added 28 commits December 1, 2023 22:28
@GAsplund
List of news posts, new post form
f09822c
@GAsplund
Post links
8539a6c
@Oscariremma
Merge remote-tracking branch 'origin/main' into feature/news-posts
9beac42
@GAsplund
Merge branch 'main' into feature/news-posts
384d1e9
@GAsplund
Add error state
0fe9a75 
This prevents a 500 error if anything fails when fetching news, such as
an inaccessible database
@GAsplund
Change default font to Poppins
f091d0e
@GAsplund
CSS cleanup
6237ddc 
Remove all of the unused CSS variables that existed in the sample NextJS
landing page
@GAsplund
Add horizontal dividers
8be1485
@GAsplund
Get session server-side for posting
2853ac3 
The declaration of custom types are actually recommended by the
next-auth documentation, even though it might seem hacky to seemingly
just override existing types.
@GAsplund
Define dimensions for most font sizes
b2c2fbb 
Not applied to all parts of the site yet...
@GAsplund
Start layouting in line with design
983f53e 
This version does not fully look like what exists in the current design,
but it is a definite improvement from what it used to look like.
Tested and working with both light and dark theme.
@GAsplund
Resolve nicks from Gamma, formatting
4214cec 
We should *definitely* cache this later on
@GAsplund
Better "New post" layout
8af5009
@GAsplund
Render post markdown
871c80f
@GAsplund
Don't mark divider as async
203e26c
@GAsplund
Mark button as inline-flex, expose event properly
370c969
@GAsplund
Redirect on successful news post
08b9463
@GAsplund
Hide post button when not active in division
38ebe6a 
Start creating an auth service to abstract specific permissions from
other services
@GAsplund
Show group written for correctly
f902f48
@GAsplund
Separate form for new post into components
30f999b 
Also add ability to post for certain groups
@GAsplund
Remove unnecessary news item from header
4985916
@GAsplund
Styled dropdown list
79d8fac
@GAsplund
Show news preview
98ee46c
@GAsplund
Add buttons to edit and delete posts
1ca0339
@GAsplund
Better post action button layout
7db6868
@GAsplund
Edit and remove posts, display edited date
412ab55
@GAsplund
Disallow non-owning users from editing news posts
7dc3dac
@GAsplund
Show post previews better
ff21aef
Oscariremma
Oscariremma requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Oscariremma Oscariremma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good.
One thing that i thought about is that we may want some kind of confirmation before deleting a news post?
But otherwise, once the docker build issue is fixed I am ready to approve this.

@Oscariremma Oscariremma merged commit facf01a into main Feb 6, 2024
5 checks passed
@Oscariremma Oscariremma deleted the feature/news-posts branch February 6, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oscariremma Oscariremma Oscariremma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GAsplund @Oscariremma