Hybrid-Recursive Feature Elimination #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LastShekel
requested changes
May 19, 2021
ITMO_FS/hybrid/hybrid_rfe.py
Outdated
| for f in features[:int(len(Xij) / 2)]: | ||
| Xk[-1].append(Xij[f]) | ||
|
|
||
| svm = SVC(kernel='linear') |
There was a problem hiding this comment.
Here you start to initialise some models, but you should set them as parameter (list of models, for example) and add it as a parameter into the init function.
ITMO_FS/hybrid/hybrid_rfe.py
Outdated
| from sklearn.ensemble import GradientBoostingClassifier | ||
|
|
||
|
|
||
| def hybrid_rfe(X_input, y_input, m=None, weighted=True, k=5, feature_names=None): |
There was a problem hiding this comment.
Since you are creating a hybrid RFE you should create it as class
ITMO_FS/hybrid/hybrid_rfe.py
Outdated
| features_best = features | ||
|
|
||
| X_result = [] | ||
| for Xi in X_input: |
There was a problem hiding this comment.
this should be done via list comprehension (https://www.w3schools.com/python/python_lists_comprehension.asp)
ITMO_FS/hybrid/hybrid_rfe.py
Outdated
| svm.fit(Xk, yk) | ||
| rf.fit(Xk, yk) | ||
| gbm.fit(Xk, yk) | ||
| score = (svm.score(Xk, yk) + rf.score(Xk, yk) + gbm.score(Xk, yk)) / 3 |
There was a problem hiding this comment.
It is better to use this mean function as parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.