This repository has been archived by the owner on Jun 13, 2020. It is now read-only.
Added catalog navigation inside mod.php #321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i need to test this more One thing I don't like is that we can't just use the existing function in templates/themes somehow, in case we want to change the catalog we'd need to do it in two places. We don't really respect DRY all that much but we should start |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #316, I have added nondestructive routing edits so mods can use the catalog without leaving mod.php. It repurposes the catalog build script into a dynamic display (similar to how mod.php handles displaying the index page, I think...).
It works on my local environment.