Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce use of magic numbers #33

Merged
merged 4 commits into from
Nov 23, 2024
Merged

Reduce use of magic numbers #33

merged 4 commits into from
Nov 23, 2024

Conversation

ctz
Copy link
Owner

@ctz ctz commented Nov 22, 2024

No description provided.

Copy link

codspeed-hq bot commented Nov 22, 2024

CodSpeed Performance Report

Merging #33 will not alter performance

Comparing jbp-magic-numbers (eec0eaf) with main (2ec4105)

Summary

✅ 126 untouched benchmarks

@ctz ctz force-pushed the jbp-magic-numbers branch 3 times, most recently from 81b0e97 to d18abe2 Compare November 22, 2024 21:51
@ctz ctz marked this pull request as ready for review November 23, 2024 17:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.58974% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.64%. Comparing base (2ec4105) to head (eec0eaf).

Files with missing lines Patch % Lines
graviola/src/mid/p384.rs 93.10% 2 Missing ⚠️
rustls-graviola/src/hash.rs 0.00% 2 Missing ⚠️
graviola/src/mid/p256.rs 96.77% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   97.64%   97.64%           
=======================================
  Files         162      162           
  Lines       37109    37115    +6     
=======================================
+ Hits        36236    36242    +6     
  Misses        873      873           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ctz ctz merged commit 69b5a6e into main Nov 23, 2024
16 checks passed
@ctz ctz deleted the jbp-magic-numbers branch November 23, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants