Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home Screen adjustments and improvements #101

Merged
merged 6 commits into from
Mar 22, 2025
Merged

Conversation

04jono
Copy link
Member

@04jono 04jono commented Mar 18, 2025

Overview

  • Flattened and partially decluttered HomeViewModel with extracted composables
  • Removed instances of viewmodels and navcontroller being passed into child composables
  • Provide a toast when a location is already favorited, fix closing animation for add favorites bottom sheet
  • Fix UI bug where favorites bottom panel can overlap main search area

Changes Made

  • LoadingLocationItems composable to share UI over all instances of location search
  • AddFavoritesSearchSheet and BottomSheetContent
  • Separate composable for main search bar

Test Coverage

Pixel 3a emulator

Next Steps (delete if not applicable)

To resolve the home screen decluttering issue, we should consider moving toward using abstract base class viewmodels and uistates for entire screens

Related PRs or Issues (delete if not applicable)

Fixes #79

Screenshots (delete if not applicable)

untitled.webm

@04jono 04jono requested review from zachseidner1 and Mihilih March 18, 2025 18:49
Copy link
Collaborator

@zachseidner1 zachseidner1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job with this! Most of it looks very clean but there are some minor things I'd appreciate if you address. Nice work ✨

@04jono 04jono requested a review from zachseidner1 March 20, 2025 23:06
Copy link
Collaborator

@zachseidner1 zachseidner1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit but you're good

@04jono 04jono merged commit 73479b1 into main Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a toast when the user tries to add a favorite they already have
2 participants