-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home Screen adjustments and improvements #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job with this! Most of it looks very clean but there are some minor things I'd appreciate if you address. Nice work ✨
app/src/main/java/com/cornellappdev/transit/ui/components/AddFavoritesSearchSheet.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/transit/ui/components/AddFavoritesSearchSheet.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/transit/ui/components/AddFavoritesSearchSheet.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/transit/ui/components/BottomSheetContent.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/transit/ui/components/LoadingLocationItems.kt
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/transit/ui/components/SearchSuggestions.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/cornellappdev/transit/ui/screens/HomeScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit but you're good
Overview
Changes Made
Test Coverage
Pixel 3a emulator
Next Steps (delete if not applicable)
To resolve the home screen decluttering issue, we should consider moving toward using abstract base class viewmodels and uistates for entire screens
Related PRs or Issues (delete if not applicable)
Fixes #79
Screenshots (delete if not applicable)
untitled.webm