Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edited dev workflow file and dockerfile #175

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Edited dev workflow file and dockerfile #175

merged 1 commit into from
Nov 18, 2024

Conversation

JoshD94
Copy link
Contributor

@JoshD94 JoshD94 commented Nov 18, 2024

Overview

Added environment variables to build

Changes Made

  • Added build arguments in github dev workflow file by accessing github secrets file
  • Loaded environment variables before running flask db migrate in dockerfile

Test Coverage

Tested locally

Related PRs or Issues (delete if not applicable)

#169

@JoshD94 JoshD94 merged commit 521c580 into master Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiestrausberg sophiestrausberg sophiestrausberg approved these changes

@Aayush-Agnihotri Aayush-Agnihotri Aayush-Agnihotri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshD94 @sophiestrausberg @Aayush-Agnihotri