Fixed capacity scraper to scrape from new URL #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,8 +6,10 @@ | |||
| # Base URL for Cornell Recreation Website | |||
| BASE_URL = "https://scl.cornell.edu/recreation/" | |||
|
|
|||
| # The path for capacities | |||
| # The old path for capacities | |||
There was a problem hiding this comment.
Is it necessary to leave the old path?
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed capacity scraper
Changes Made
Problem: The capacity scraper URL no longer works and capacity is zero for all facilities.
Solution: Found the new URL that the website references to obtain their data, grabbed the URL and created a new scraper
The new URL is this one: https://goboardapi.azurewebsites.net/api/FacilityCount/GetCountsByAccount?AccountAPIKey=355de24d-d0e4-4262-ae97-bc0c78b92839
Test Coverage
Tested locally and confirmed the scraped data is equivalent to the one displayed on the capacity website.