Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure public is in sync with isVisible when using DAP #8980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bsod90
Copy link
Contributor

@bsod90 bsod90 commented Nov 22, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@bsod90 bsod90 requested a review from a team as a code owner November 22, 2024 00:19
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:58am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:58am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:58am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:58am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:58am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:58am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:58am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:58am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 22, 2024
@bsod90 bsod90 force-pushed the bring_public_in_sync_with_is_visible branch from 6417702 to c5fa78b Compare November 22, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant