Skip to content

Commit

Permalink
Remove unused array_names parameter in executors
Browse files Browse the repository at this point in the history
  • Loading branch information
tomwhite committed Feb 14, 2024
1 parent a19cfad commit c062158
Show file tree
Hide file tree
Showing 10 changed files with 1 addition and 23 deletions.
1 change: 0 additions & 1 deletion cubed/core/array.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,6 @@ def compute(
optimize_graph=optimize_graph,
optimize_function=optimize_function,
resume=resume,
array_names=[a.name for a in arrays],
spec=spec,
**kwargs,
)
Expand Down
2 changes: 0 additions & 2 deletions cubed/core/plan.py
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ def execute(
optimize_function=None,
resume=None,
spec=None,
array_names=None,
**kwargs,
):
dag = self._finalize_dag(optimize_graph, optimize_function)
Expand All @@ -204,7 +203,6 @@ def execute(
executor.execute_dag(
dag,
callbacks=callbacks,
array_names=array_names,
resume=resume,
spec=spec,
**kwargs,
Expand Down
4 changes: 1 addition & 3 deletions cubed/runtime/executors/beam.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,7 @@ def expand(self, pcoll):
class BeamDagExecutor(DagExecutor):
"""An execution engine that uses Apache Beam."""

def execute_dag(
self, dag, callbacks=None, array_names=None, resume=None, spec=None, **kwargs
):
def execute_dag(self, dag, callbacks=None, resume=None, spec=None, **kwargs):
dag = dag.copy()
pipeline = beam.Pipeline(**kwargs)

Expand Down
1 change: 0 additions & 1 deletion cubed/runtime/executors/coiled.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ def execute_dag(
self,
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
**coiled_kwargs: Mapping[str, Any],
Expand Down
3 changes: 0 additions & 3 deletions cubed/runtime/executors/dask_distributed_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ def check_runtime_memory(spec, client):
async def async_execute_dag(
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
compute_arrays_in_parallel: Optional[bool] = None,
Expand Down Expand Up @@ -151,7 +150,6 @@ def execute_dag(
self,
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
compute_kwargs: Optional[Dict[str, Any]] = None,
Expand All @@ -162,7 +160,6 @@ def execute_dag(
async_execute_dag(
dag,
callbacks=callbacks,
array_names=array_names,
resume=resume,
spec=spec,
compute_kwargs=compute_kwargs,
Expand Down
3 changes: 0 additions & 3 deletions cubed/runtime/executors/lithops.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ def map_unordered(
def execute_dag(
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
compute_arrays_in_parallel: Optional[bool] = None,
Expand Down Expand Up @@ -241,7 +240,6 @@ def execute_dag(
self,
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
**kwargs,
Expand All @@ -250,7 +248,6 @@ def execute_dag(
execute_dag(
dag,
callbacks=callbacks,
array_names=array_names,
resume=resume,
spec=spec,
**merged_kwargs,
Expand Down
3 changes: 0 additions & 3 deletions cubed/runtime/executors/modal.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def run_remotely(self, input, func=None, config=None):
def execute_dag(
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
cloud: Optional[str] = None,
Expand Down Expand Up @@ -151,7 +150,6 @@ def execute_dag(
self,
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
**kwargs,
Expand All @@ -160,7 +158,6 @@ def execute_dag(
execute_dag(
dag,
callbacks=callbacks,
array_names=array_names,
resume=resume,
spec=spec,
**merged_kwargs,
Expand Down
3 changes: 0 additions & 3 deletions cubed/runtime/executors/modal_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def pipeline_to_stream(app_function, name, pipeline, **kwargs):
async def async_execute_dag(
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
cloud: Optional[str] = None,
Expand Down Expand Up @@ -155,7 +154,6 @@ def execute_dag(
self,
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
**kwargs,
Expand All @@ -165,7 +163,6 @@ def execute_dag(
async_execute_dag(
dag,
callbacks=callbacks,
array_names=array_names,
resume=resume,
spec=spec,
**merged_kwargs,
Expand Down
1 change: 0 additions & 1 deletion cubed/runtime/executors/python.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def execute_dag(
self,
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
**kwargs,
Expand Down
3 changes: 0 additions & 3 deletions cubed/runtime/executors/python_async.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ def pipeline_to_stream(
async def async_execute_dag(
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
compute_arrays_in_parallel: Optional[bool] = None,
Expand Down Expand Up @@ -125,7 +124,6 @@ def execute_dag(
self,
dag: MultiDiGraph,
callbacks: Optional[Sequence[Callback]] = None,
array_names: Optional[Sequence[str]] = None,
resume: Optional[bool] = None,
spec: Optional[Spec] = None,
**kwargs,
Expand All @@ -134,7 +132,6 @@ def execute_dag(
async_execute_dag(
dag,
callbacks=callbacks,
array_names=array_names,
resume=resume,
spec=spec,
**kwargs,
Expand Down

0 comments on commit c062158

Please sign in to comment.