Refactor pipeline to reduce coupling between runtime and primitive layers #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
force-pushed
the
primitive-operation
branch
from
273cc0c to
a334cbe
Compare
…yers Introduce PrimitiveOperation that encapsulates information for blockwise and rechunk that the runtime layer does not need
tomwhite
force-pushed
the
primitive-operation
branch
from
a334cbe to
8df7472
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes a separation between the pipeline (run by the runtime layer) and the primitive operation (blockwise or rechunk) that may have extra information that the runtime doesn't care about (e.g. target array). With this change there is no need to update the runtime when new information is added that only blockwise or rechunk needs.