Implement virtual array indexing using ndindex #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
force-pushed
the
remove-zarr-templates
branch
from
fad0a06 to
db71acf
Compare
tomwhite
force-pushed
the
remove-zarr-templates
branch
from
db71acf to
86688d5
Compare
tomwhite
force-pushed
the
remove-zarr-templates
branch
from
86688d5 to
201f950
Compare
This was referenced Jun 17, 2024
Closed
tomwhite
force-pushed
the
remove-zarr-templates
branch
from
201f950 to
fcd6286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason to do this is that it removes a dependency on an internal Zarr API (
BasicIndexer). It adds a dependency onndeindex, but it's lightweight, and will be used for #403 later.