Adding compile_function as execute option.
#536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to use jit or aot compilation during the dag finalization process within executors. It should work straightforwardly on jax/numba style jit compilation. It's possible, but maybe ugly, to perform jax-aot-style compilation.
|
I think this PR is ready to merge. The next things to explore in this area are:
|
tomwhite
reviewed
Aug 4, 2024
There was a problem hiding this comment.
This looks good - thanks for submitting it @alxmrs! Submitting the JAX work in smaller chunks is a good idea.
I made a couple of suggestions for changes, and it also looks like mypy is complaining.
(I'm interested in examples where compilation gives a performance increase - but that's not a blocker to merging this.)
- remove todo for new test - use pytest conventions
Simplifying type to make mypy happy.
tomwhite
approved these changes
Aug 7, 2024
|
Thanks @alxmrs! |
thodson-usgs
pushed a commit
to thodson-usgs/cubed
that referenced
this pull request
Oct 24, 2024
* Adding `compile_function` as execute option. This allows users to use jit or aot compilation during the dag finalization process within executors. It should work straightforwardly on jax/numba style jit compilation. It's possible, but maybe ugly, to perform jax-aot-style compilation. * Add numba for compilation tests. * Singlequotes not needed. * Update function doc. * Added another compile test for failure case. * Added another test to ensure config was applied. * Improve tests - remove todo for new test - use pytest conventions * I don’t think numba jit works well on jax arrays. * Update plan.py Simplifying type to make mypy happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to use jit or aot compilation during the dag finalization process within executors. It should work straightforwardly on jax/numba style jit compilation. It's possible, but maybe ugly, to perform jax-aot-style compilation.
This should help make progress towards #304.
(Note to reviewer: I realized this could be merged ahead of #508, so I pulled it out into a non-dependent PR).